Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS S3 Actions - Adding new documentation on supported integrations, and mappings #7330

Merged
merged 4 commits into from
Dec 18, 2024

Conversation

jpang007
Copy link
Contributor

Proposed changes

Added in extra documentation on mapping functionality as well as the supported Segment Feature Integrations

Merge timing

ASAP once approved

Related issues (optional)

N/A

@jpang007 jpang007 requested a review from a team as a code owner December 16, 2024 18:38
@jpang007 jpang007 requested review from forstisabella and tcgilbert and removed request for forstisabella December 16, 2024 18:38
@@ -25,6 +25,12 @@ The AWS S3 (Actions) destination enhances this capability by introducing configu

* **Enhanced Delivery Controls**. The destination provides advanced options for batch size controls and file naming conventions. These controls can help optimize efficiency and simplify data retrieval workflows.

## Supported Integrations
The AWS S3 (Actions) Destination supports the following Segment features as supported native Destination integration points:
* rETL
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* rETL
* [Reverse ETL](/docs/connections/reverse-etl/)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

## Supported Integrations
The AWS S3 (Actions) Destination supports the following Segment features as supported native Destination integration points:
* rETL
* Classic and Linked Audiences
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Classic and Linked Audiences
* [Classic and Linked Audiences](/docs/engage/audiences/)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

The AWS S3 (Actions) Destination supports the following Segment features as supported native Destination integration points:
* rETL
* Classic and Linked Audiences
* Connections
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Connections
* [Connections](/docs/connections/)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@@ -36,7 +42,7 @@ Ensure you have the following in place before configuring the AWS S3 (Actions) d
- IAM Access IDs: Prepare your AWS IAM ARN ID and IAM External ID. These will be needed to authenticate and authorize Segment with your S3 bucket.


### Step 1: Create an IAM role in the AWS console
## Step 1: Create an IAM role in the AWS console
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer to keep all of the setup steps one heading level under the Getting started header to keep a consistent pattern across other integrations!

Suggested change
## Step 1: Create an IAM role in the AWS console
### Step 1: Create an IAM role in the AWS console

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@@ -81,8 +87,9 @@ To set up the IAM role to properly authorize Segment with the AWS S3 (Actions) d
]
}
```

## Step 2: Add the AWS S3 (Actions) Destination in Segment
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## Step 2: Add the AWS S3 (Actions) Destination in Segment
### Step 2: Add the AWS S3 (Actions) Destination in Segment

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@forstisabella one of the reasons @jpang007 submitted this was to get all the steps in the side-nav:
Screenshot 2024-12-16 at 3 47 15 PM

I think we should either show all in side-nav or none. That said, I will defer to @forstisabella on what we should use as the standard

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That makes sense! I think we shouldn't have the steps in the side nav to stay consistent with other destinations' docs!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

2. Define the Event Trigger. If multiple types are accepted in the Event Trigger, the generated files will automatically be split by type in S3 (i.e Track events file and Identifer events file).
3. Configure the Column Mappings that are needed, if any of the default columns are **not** needed, leave the value blank. You can also choose to add new mapping fields to set up any customized columns as needed.
4. Configure the Other Settings as needed.
5. Enable the Mapping and start sending data!
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
5. Enable the Mapping and start sending data!
5. Enable the Mapping.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

1. Add a new **Sync to S3** Action into the destination.
2. Define the Event Trigger. If multiple types are accepted in the Event Trigger, the generated files will automatically be split by type in S3 (i.e Track events file and Identifer events file).
3. Configure the Column Mappings that are needed, if any of the default columns are **not** needed, leave the value blank. You can also choose to add new mapping fields to set up any customized columns as needed.
4. Configure the Other Settings as needed.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
4. Configure the Other Settings as needed.
4. Configure any additional settings as required.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done


1. Add a new **Sync to S3** Action into the destination.
2. Define the Event Trigger. If multiple types are accepted in the Event Trigger, the generated files will automatically be split by type in S3 (i.e Track events file and Identifer events file).
3. Configure the Column Mappings that are needed, if any of the default columns are **not** needed, leave the value blank. You can also choose to add new mapping fields to set up any customized columns as needed.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
3. Configure the Column Mappings that are needed, if any of the default columns are **not** needed, leave the value blank. You can also choose to add new mapping fields to set up any customized columns as needed.
3. Configure the Column Mappings. If you don't need any of the default columns, leave the value blank. You can also choose to add new mapping fields to set up customized columns as needed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done


1. Add a new **Sync to S3** Action into the destination.
2. Define the Event Trigger. If multiple types are accepted in the Event Trigger, the generated files will automatically be split by type in S3 (i.e Track events file and Identifer events file).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
2. Define the Event Trigger. If multiple types are accepted in the Event Trigger, the generated files will automatically be split by type in S3 (i.e Track events file and Identifer events file).
2. Define the Event Trigger. If multiple types are accepted in the Event Trigger, the generated files will automatically be split by type in S3 (for example, you might have a Track events file and an Identify events file).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done


{% include components/actions-fields.html settings="true"%}

## Step 3: Configure the AWS S3 (Actions) Destination mappings
To finish the configuration, finalize the mappings of the new AWS S3 (Actions) Destination:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
To finish the configuration, finalize the mappings of the new AWS S3 (Actions) Destination:
To finish the configuration, add mappings to your new AWS S3 (Actions) Destination:

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

tcgilbert
tcgilbert previously approved these changes Dec 16, 2024
@forstisabella forstisabella merged commit 77f3516 into develop Dec 18, 2024
4 checks passed
@forstisabella forstisabella deleted the segment-actions-s3-update branch December 18, 2024 21:37
Copy link
Contributor

Thank you for your contribution! Your pull request is merged, but may take a day or two to appear on the site.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants