Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Classic McEliece Testspecification #187

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Classic McEliece Testspecification #187

wants to merge 2 commits into from

Conversation

FAlbertDev
Copy link
Collaborator

Test specification for Botan's Classic McEliece implementation. Note that the CI will fail until the PR is merged into Botan.

@FAlbertDev FAlbertDev added this to the Botan 3.4.0 milestone Feb 15, 2024
@FAlbertDev FAlbertDev self-assigned this Feb 15, 2024
Copy link
Collaborator

@atreiber94 atreiber94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Added some comments

docs/testspec/src/12_pubkey_kem.rst Outdated Show resolved Hide resolved
docs/testspec/src/12_pubkey_kem.rst Outdated Show resolved Hide resolved
docs/testspec/src/12_pubkey_kem.rst Show resolved Hide resolved
docs/testspec/src/12_pubkey_kem.rst Outdated Show resolved Hide resolved
docs/testspec/src/12_pubkey_kem.rst Show resolved Hide resolved
docs/testspec/src/12_pubkey_kem.rst Show resolved Hide resolved
docs/testspec/src/12_pubkey_kem.rst Outdated Show resolved Hide resolved
docs/testspec/src/12_pubkey_kem.rst Outdated Show resolved Hide resolved
docs/testspec/src/12_pubkey_kem.rst Outdated Show resolved Hide resolved
@FAlbertDev
Copy link
Collaborator Author

FAlbertDev commented Mar 11, 2024

Thanks for your review, @atreiber94. Many of your suggestions refer to the generic KEM test description. Therefore, they are also relevant for the descriptions of FrodoKEM and Kyber. I applied them there as well.

Copy link
Collaborator

@atreiber94 atreiber94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, lgtm!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants