Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract multiple EVM logs from a single WASM event #2050

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

codchen
Copy link
Collaborator

@codchen codchen commented Jan 22, 2025

Describe your changes and provide context

It is possible for a single WASM event to contain multiple actions, so we should be translating each action, instead of each WASM event, into individual EVM logs. This PR changes the translation logic as such.

Testing performed to validate your change

todo

Copy link

codecov bot commented Jan 22, 2025

Codecov Report

Attention: Patch coverage is 89.37008% with 27 lines in your changes missing coverage. Please review.

Project coverage is 61.57%. Comparing base (8095774) to head (467463f).

Files with missing lines Patch % Lines
app/receipt.go 89.37% 15 Missing and 12 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2050      +/-   ##
==========================================
+ Coverage   61.28%   61.57%   +0.29%     
==========================================
  Files         264      264              
  Lines       24566    24508      -58     
==========================================
+ Hits        15056    15092      +36     
+ Misses       8384     8297      -87     
+ Partials     1126     1119       -7     
Files with missing lines Coverage Δ
app/receipt.go 87.04% <89.37%> (+7.99%) ⬆️

... and 5 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant