Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Endpoint route fixes #138

Merged
merged 4 commits into from
Sep 19, 2024
Merged

Endpoint route fixes #138

merged 4 commits into from
Sep 19, 2024

Conversation

besated
Copy link
Contributor

@besated besated commented Sep 19, 2024

Describe the changes to the documentation

  • Fixed color scheme on the endpoint route pages
  • Set static paths and props on the dynamic routes, so endpoint routes are generated on build

Notes

  • Had to move the endpoints to /endpoints/cosmos/api to prevent duplicate endpoints
  • There's a few formatting changes bc of prettier
  • Had to set a specific version of Next and React

@besated besated requested a review from a team as a code owner September 19, 2024 00:01
case 'light':
return 'light';
default:
return undefined;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

curious why not make a default either one?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

undefined will just use whatever the current theme is set on mantine - which i think is more accurate than choosing one here

@besated besated merged commit 685780f into main Sep 19, 2024
1 check passed
@besated besated deleted the fix/dark-mode branch September 19, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants