Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved Wallet Documentation #73

Merged
merged 1 commit into from
May 29, 2024
Merged

Improved Wallet Documentation #73

merged 1 commit into from
May 29, 2024

Conversation

codebycarson
Copy link
Contributor

@codebycarson codebycarson commented May 29, 2024

PR Description

This pull request enhances the documentation on wallets for the Sei blockchain by:

  1. Adding Detailed Wallet Information:

    • Expanded the section on the importance of wallets.
    • Explained different types of wallets: Software Wallets, Hardware Wallets, and Passkey-based Wallets.
  2. Introducing a Comprehensive Wallet Table:

    • Detailed a table of recommended wallets with their EVM and Cosmos support, authentication methods, coin types, wallet types, and mobile support.
    • Included links to each wallet for easy access.
  3. Adding a Section on Other Wallets:

    • Added a section on other wallets that support the Sei blockchain, particularly those designed for the Cosmos ecosystem.
    • Included wallets such as Leap and Keplr, providing information on their support and features.

Detailed Changes

  • Updated wallets.md to include a comprehensive table of recommended wallets.
  • Added descriptions for each wallet type and their importance.
  • Created a new section for other Cosmos wallets that support Sei, enhancing the options available for users.

@codebycarson codebycarson requested a review from besated May 29, 2024 05:08
@codebycarson codebycarson requested a review from a team as a code owner May 29, 2024 05:08
@codebycarson codebycarson changed the title Improved wallet page Enhance Wallet Documentation with Comprehensive Details and Additional Wallets May 29, 2024
@codebycarson codebycarson changed the title Enhance Wallet Documentation with Comprehensive Details and Additional Wallets Improved Wallet Documentation May 29, 2024
Copy link
Contributor

@cordt-sei cordt-sei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another great feature of wallets like MM or Keplr is that the browser extension actually uses a blocklist to warn if you're trying to view a reported and confirmed scam domain.

https://github.com/chainapsis/phishing-block-list/blob/main/block-list.txt

Looks good anyway.

@codebycarson codebycarson merged commit 2309ec3 into main May 29, 2024
1 check passed
@codebycarson codebycarson deleted the feature/fin-wallet branch May 29, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants