Automatix_cmd Merge #66
Open
+1,564
−222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Experimental features should be deactivated on default, even though it's a cool feature ;)
To avoid over long and changing lines.
Also python requirement increased to >=3.10
Add RUNNING_INSIDE_AUTOMATIX environment variable
Handing over all the globals of the main programm seems unnecessary and dangerous.
Builtins seem to be included anyway.
a_vars to avoid shadowing vars() Also adding tests for assignment.
This is to have a better separation between the PERSISTENT_VARS the user sets and the programmaticly set variables, like a_vars, PVARS, AbortException, ... Fixes also a bug, where assignments in python commands did not work, because the a_vars had been overridden by PERSISTENT_VARS.
Refactor python vars and add Python debug shell
Some screen versions do not have 'GNU' or 'FAU' in their version output. We do not know which version it might be, but we can have a try.
Since version 5.0.0 of GNU Screen the term "GNU" is no longer part of the version output. This makes it difficult to identify the GNU version safely. Therefore we asume the correct version if we do not have clear hints for the false (FAU) version.
Fix screen version check
Add example for file content assignment with "FILE_" syntax
jpaul-seibert
requested review from
dracador,
phosei,
fkusei and
sschmachtel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR merges all the changes from https://github.com/vanadinit/automatix_cmd
I first considered rewriting or just taking parts of the code, but there was also some major refactoring of the main code so I felt like I would do all the work a second time. Feel free to comment and make suggestions for improvements.