[RabbitMQ] Updatings values.yaml to enable monitoring and readme instructions #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grebois
changed the title
grebois
changed the title
sekka1
reviewed
Jul 20, 2018
| - [Updating from 1.6.1](#updating-from-161) | ||
| - [Exporting metric to Prometheus](#exporting-metric-to-prometheus) | ||
| - [Verify metrics are being published](#verify-metrics-are-being-published) | ||
| - [Finally verify that the target is in prometheus](#finally-verify-that-the-target-is-in-prometheus) |
There was a problem hiding this comment.
I like the ToC. Did you use a generator for this?
There was a problem hiding this comment.
sekka1
reviewed
Jul 20, 2018
| @@ -97,3 +119,521 @@ rabbitmqAmqpsSupport: | |||
| ssl_options.verify = verify_peer | |||
| ssl_options.fail_if_no_peer_cert = false | |||
| ``` | |||
|
|
|||
| # Updating from 1.6.1 | |||
There was a problem hiding this comment.
Can we put everything below this in another .md file named updating_from_1.6.1.md and either link to it or just leave it as another file, because this chart will be updated again and the question is, do you keep the 1.6.1 update here or do you delete it or what? I think moving it out to another file now makes the main README.md clean and approachable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.