update y axis label to use D_cand as well

seldonian-toolkit · Sep 26, 2022 · 6781c09 · 6781c09
1 parent 986f7ec
commit 6781c09
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 2 deletions.
diff --git a/examples/loan_tutorial/loan_cs.png b/examples/loan_tutorial/loan_cs.png
diff --git a/examples/loan_tutorial/plot_loan_cs.py b/examples/loan_tutorial/plot_loan_cs.py
@@ -7,7 +7,7 @@
 	cs_file = './logs/candidate_selection_log0.p'
 	savename = './loan_cs.png'
 	solution_dict = load_pickle(cs_file)
-	save=False
+	save=True
 	show=not save
 	fig = plot_gradient_descent(solution_dict,
 		primary_objective_name='log loss',

diff --git a/seldonian/utils/plot_utils.py b/seldonian/utils/plot_utils.py
@@ -82,7 +82,7 @@ def plot_gradient_descent(
         g_vals_this_constraint = [x[constraint_index][0] for x in g_vals]
         ax_g.plot(np.arange(len(g_vals)),g_vals_this_constraint,linewidth=2)
         ax_g.set_xlabel("Iteration")
-        ax_g.set_ylabel(rf"$\mathrm{{HCUB}}(\hat{{g}}_{{{row_number}}})$",fontsize=fontsize)
+        ax_g.set_ylabel(rf"$\mathrm{{HCUB}}(\hat{{g}}_{{{row_number}}}(\theta,D_\mathrm{{cand}}))$",fontsize=fontsize)
         ax_g.fill_between(np.arange(len(g_vals)),0.0,1e6,color='r',zorder=0,alpha=0.5)
         ax_g.set_ylim(min(-0.25,min(g_vals_this_constraint)),max(0.25,max(g_vals_this_constraint)*1.2))
         ax_g.axvline(x=best_index,linestyle='--',color='k')