add electron as a source (xs sized PR) #1921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Don't forget to add
|
| Name | Link |
|---|---|
| 🔨 Latest commit | be9a0c7 |
| 🔍 Latest deploy log | https://app.netlify.com/sites/semgrep-docs-prod/deploys/6791ee4f7fd1dd00082c0dfd |
| 😎 Deploy Preview | https://deploy-preview-1921--semgrep-docs-prod.netlify.app |
| 📱 Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
khorne3
approved these changes
Jan 23, 2025
|
@khorne3 I thought about it - my first pass was "Period of reachability rule coverage for advisory sources" which sounded pretty weird. (We're going to have a third rule source within 1-2 months so I had to generalize to "security advisory sources" or some such.) Also there was no mention of "time period coverage" during the product-updates announcement so I'm not sure we go back to 201X for Electron specifically. |
|
@s-santillan That makes sense. If/when we need to make these updates, maybe we just shorten the header to "Period of reachability rule coverage" and make sure the text is descriptive enough to be clear |
s-santillan
deleted the
sara/tec-267-docs-update-we-now-integrate-electron-release-notes-for
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for improving Semgrep Docs 😀
Please ensure
Tiny PR. I checked our Advisories tab and we don't show the source of the CVE (yet) so I just listed electron release notes as a source.