Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update docusaurus to 3.7.0 #1974

Merged
merged 1 commit into from
Feb 14, 2025
Merged

update docusaurus to 3.7.0 #1974

merged 1 commit into from
Feb 14, 2025

Conversation

s-santillan
Copy link
Collaborator

@s-santillan s-santillan commented Feb 13, 2025

Thanks for improving Semgrep Docs 😀

Please ensure

  • It builds, all components green
  • A technical writer reviews the content or PR

@s-santillan s-santillan requested a review from khorne3 February 13, 2025 22:17
@s-santillan s-santillan self-assigned this Feb 13, 2025
Copy link

netlify bot commented Feb 13, 2025

Don't forget to add /docs at the end of the deploy preview site URL!

Name Link
🔨 Latest commit 67154a0
🔍 Latest deploy log https://app.netlify.com/sites/semgrep-docs-prod/deploys/67ae6f65589dc5000835ed3d
😎 Deploy Preview https://deploy-preview-1974--semgrep-docs-prod.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@s-santillan s-santillan changed the title update lockfiles update docusaurus to 3.7.0 Feb 13, 2025
Copy link
Collaborator

@khorne3 khorne3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know what the neutral tests mean, but it builds and looks fine to me

@s-santillan
Copy link
Collaborator Author

Good call out on specifying what the warnings are. I'll list their broad categories in the order in which they appear:

  1. Previously, the build log complained about the .svg files (which are rendered correctly). The warning still appears in 3.7.0.
  2. This one is new:
    Resolving 'terser-webpack-plugin/dist/minify' in /opt/build/repo/node_modules/terser-webpack-plugin/dist for build dependencies doesn't lead to expected result '/opt/build/repo/node_modules/terser-webpack-plugin/dist/minify.js', but to '/opt/build/repo/node_modules/terser-webpack-plugin/node_modules/terser-webpack-plugin/dist/minify.js' instead. Resolving dependencies are ignored for this path.
    
    It also doesn't seem to affect the actual serving of pages. But it is weird that it suddenly popped out in Docusaurus 3.7.0.
  3. We have a new slew of broken links related to my changes in Supported languages + a few others that have come up over time - I will fix these in a separate PR.

@s-santillan s-santillan merged commit 41829d7 into main Feb 14, 2025
7 checks passed
@s-santillan s-santillan deleted the sara/update-docusaurus-370 branch February 14, 2025 11:14
@s-santillan s-santillan added the infra Search, frontend, modal, navbar, workflows label Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infra Search, frontend, modal, navbar, workflows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants