Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: mutable manager.remove_obsolete_receipts #185

Merged
merged 1 commit into from
Nov 6, 2023
Merged

fix: mutable manager.remove_obsolete_receipts #185

merged 1 commit into from
Nov 6, 2023

Conversation

aasseman
Copy link
Contributor

Remove unnecessary mutability that makes usage a little bit harder.

@aasseman aasseman added the type:bug Something isn't working label Oct 30, 2023
@aasseman aasseman self-assigned this Oct 30, 2023
@aasseman aasseman requested a review from ColePBryan as a code owner October 30, 2023 17:42
@github-actions
Copy link

Pull Request Test Coverage Report for Build 6696679791

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 82.176%
Totals Coverage Status
Change from base Build 6696126630: 0.0%
Covered Lines: 1231
Relevant Lines: 1498
💛 - Coveralls

@github-actions

This comment has been minimized.

Sign in to view
@aasseman aasseman force-pushed the aasseman/fix_unnecessary_mut branch from ce1fe27 to ca1a01e Compare October 30, 2023 18:27
@aasseman
Copy link
Contributor Author

Rebased onto latest main

@github-actions
Copy link

🤖 Cargo Audit Report 🤖

(Empty means OK! 👍)

ColePBryan
ColePBryan approved these changes Nov 6, 2023
View reviewed changes
Copy link
Contributor

@ColePBryan ColePBryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@ColePBryan ColePBryan merged commit 3d247c0 into main Nov 6, 2023
7 checks passed
@ColePBryan ColePBryan deleted the aasseman/fix_unnecessary_mut branch November 6, 2023 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ColePBryan ColePBryan ColePBryan approved these changes

Assignees

@aasseman aasseman

Labels
type:bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aasseman @ColePBryan