Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): Supply EIP712 domain sep with prefilled version and name #210

Merged
merged 1 commit into from
Feb 2, 2024
Merged

feat(core): Supply EIP712 domain sep with prefilled version and name #210

merged 1 commit into from
Feb 2, 2024

Conversation

aasseman
Copy link
Contributor

@aasseman aasseman commented Feb 2, 2024

No description provided.

@aasseman aasseman added the enhancement New feature or request label Feb 2, 2024
@aasseman aasseman self-assigned this Feb 2, 2024
@aasseman aasseman requested a review from gusinacio as a code owner February 2, 2024 22:14
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 2, 2024

🤖 Cargo Audit Report 🤖

(Empty means OK! 👍)

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 2, 2024

Pull Request Test Coverage Report for Build 7762135905

  • 0 of 11 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 73.678%
Totals Coverage Status
Change from base Build 7589648900: 0.2%
Covered Lines: 1324
Relevant Lines: 1797
💛 - Coveralls

gusinacio
gusinacio approved these changes Feb 2, 2024
View reviewed changes
Copy link
Contributor

@gusinacio gusinacio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aasseman aasseman merged commit 2ed564b into main Feb 2, 2024
8 checks passed
@aasseman aasseman deleted the aasseman/feat_provide_eip712_sep branch February 2, 2024 23:56
@semiotic-labs-pr-automation semiotic-labs-pr-automation bot mentioned this pull request Jan 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gusinacio gusinacio gusinacio approved these changes

Assignees

@aasseman aasseman

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aasseman @gusinacio