Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: new project structure #216

Merged
merged 11 commits into from
Mar 11, 2024
Merged

Conversation

gusinacio
Copy link
Contributor

@gusinacio gusinacio commented Mar 11, 2024

  • Rename executor to context
  • Rename modules:
    • tap_receipt to receipt
    • receipts_aggregate_voucher to rav
    • tap_manager to manager
  • Move SignedReceipt from manager to receipt
  • Move SignedRAV from manager to rav
  • Rename EscrowAdapter to EscrowHandler
  • Remove ReceivedReceipt and StoreReceipt
  • Rename mock to in_memory context
  • Remove serialize from RAVRequest
  • Remove ReceiptAuditor and use their methods inside EscrowHandler
  • Move checks::mock to memory::checks

Signed-off-by: Gustavo Inacio <[email protected]>
ExecutorMock -> InMemoryContext
adapters -> strategy

Signed-off-by: Gustavo Inacio <[email protected]>
Signed-off-by: Gustavo Inacio <[email protected]>
Signed-off-by: Gustavo Inacio <[email protected]>
Signed-off-by: Gustavo Inacio <[email protected]>
@gusinacio gusinacio requested a review from aasseman as a code owner March 11, 2024 17:45

This comment has been minimized.

@coveralls
Copy link

coveralls commented Mar 11, 2024

Pull Request Test Coverage Report for Build 8237551665

Details

  • 126 of 160 (78.75%) changed or added relevant lines in 9 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.4%) to 79.263%

Changes Missing Coverage Covered Lines Changed/Added Lines %
tap_core/src/rav/request.rs 0 1 0.0%
tap_core/src/receipt/received_receipt.rs 13 15 86.67%
tap_core/src/receipt/checks.rs 0 3 0.0%
tap_core/src/manager/adapters/escrow.rs 30 36 83.33%
tap_core/src/manager/context/memory.rs 58 80 72.5%
Totals Coverage Status
Change from base Build 8237367878: -0.4%
Covered Lines: 925
Relevant Lines: 1167

💛 - Coveralls

@gusinacio gusinacio changed the title Gusinacio/new project structure Refactor: new project structure Mar 11, 2024
@gusinacio gusinacio self-assigned this Mar 11, 2024
Signed-off-by: Gustavo Inacio <[email protected]>
@gusinacio gusinacio enabled auto-merge March 11, 2024 18:00
Copy link

🤖 Cargo Audit Report 🤖

(Empty means OK! 👍)

Copy link
Contributor

@aasseman aasseman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gusinacio gusinacio merged commit 2a0bf49 into main Mar 11, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants