Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cover more unit tests on rav/receipts #228

Merged
merged 3 commits into from
Jun 7, 2024
Merged

Cover more unit tests on rav/receipts #228

merged 3 commits into from
Jun 7, 2024

Conversation

carlosvdr
Copy link
Contributor

Added extra unit tests for:

  • batch timestamp check for receipts
  • batch uniqueness check for receipts
  • ignore invalid receipts for rav creation
  • deny rav due to wrong value

@carlosvdr carlosvdr self-assigned this Jun 5, 2024
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 5, 2024

Pull Request Test Coverage Report for Build 9390499906

Details

  • 57 of 57 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+1.9%) to 80.766%
Totals Coverage Status
Change from base Build 8634497405: 1.9%
Covered Lines: 970
Relevant Lines: 1201
💛 - Coveralls

2 similar comments
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 5, 2024

Pull Request Test Coverage Report for Build 9390499906

Details

  • 57 of 57 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+1.9%) to 80.766%
Totals Coverage Status
Change from base Build 8634497405: 1.9%
Covered Lines: 970
Relevant Lines: 1201
💛 - Coveralls

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 5, 2024

Pull Request Test Coverage Report for Build 9390499906

Details

  • 57 of 57 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+1.9%) to 80.766%
Totals Coverage Status
Change from base Build 8634497405: 1.9%
Covered Lines: 970
Relevant Lines: 1201
💛 - Coveralls

@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 5, 2024

Pull Request Test Coverage Report for Build 9390581960

Details

  • 57 of 57 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+1.9%) to 80.766%
Totals Coverage Status
Change from base Build 8634497405: 1.9%
Covered Lines: 970
Relevant Lines: 1201
💛 - Coveralls

2 similar comments
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 5, 2024

Pull Request Test Coverage Report for Build 9390581960

Details

  • 57 of 57 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+1.9%) to 80.766%
Totals Coverage Status
Change from base Build 8634497405: 1.9%
Covered Lines: 970
Relevant Lines: 1201
💛 - Coveralls

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 5, 2024

Pull Request Test Coverage Report for Build 9390581960

Details

  • 57 of 57 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+1.9%) to 80.766%
Totals Coverage Status
Change from base Build 8634497405: 1.9%
Covered Lines: 970
Relevant Lines: 1201
💛 - Coveralls

aasseman
aasseman suggested changes Jun 5, 2024
View reviewed changes
tap_core/tests/manager_test.rs Show resolved Hide resolved
tap_core/tests/manager_test.rs Outdated Show resolved Hide resolved
tap_core/tests/manager_test.rs Outdated Show resolved Hide resolved
tap_core/tests/manager_test.rs Outdated Show resolved Hide resolved
tap_core/tests/manager_test.rs Outdated Show resolved Hide resolved
tap_core/tests/manager_test.rs Outdated Show resolved Hide resolved
tap_core/tests/manager_test.rs Outdated Show resolved Hide resolved
tap_core/src/receipt/checks.rs Show resolved Hide resolved
tap_core/src/receipt/checks.rs Show resolved Hide resolved
@carlosvdr
test: Simplified tests
43a59bc 
Signed-off-by: Carlos V <[email protected]>
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@coveralls
Copy link

coveralls commented Jun 6, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9403028813

Details

  • 57 of 57 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+1.9%) to 80.766%
Totals Coverage Status
Change from base Build 8634497405: 1.9%
Covered Lines: 970
Relevant Lines: 1201
💛 - Coveralls

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 6, 2024

🤖 Cargo Audit Report 🤖

(Empty means OK! 👍)

@coveralls
Copy link

coveralls commented Jun 6, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9403098951

Details

  • 57 of 57 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+1.9%) to 80.766%
Totals Coverage Status
Change from base Build 8634497405: 1.9%
Covered Lines: 970
Relevant Lines: 1201
💛 - Coveralls

@carlosvdr carlosvdr requested a review from aasseman June 6, 2024 21:24
aasseman
aasseman approved these changes Jun 7, 2024
View reviewed changes
Copy link
Contributor

@aasseman aasseman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@aasseman aasseman merged commit 483a712 into main Jun 7, 2024
8 checks passed
@aasseman aasseman deleted the rav-checks branch June 7, 2024 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aasseman aasseman aasseman approved these changes

@gusinacio gusinacio Awaiting requested review from gusinacio gusinacio is a code owner

Assignees

@carlosvdr carlosvdr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@carlosvdr @coveralls @aasseman