Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor!(all): remove ethers and use alloy #235

Merged
merged 3 commits into from
Aug 2, 2024
Merged

refactor!(all): remove ethers and use alloy #235

merged 3 commits into from
Aug 2, 2024

Conversation

gusinacio
Copy link
Contributor

@gusinacio gusinacio commented Aug 2, 2024 •
edited
Loading

Fixes #231

@gusinacio gusinacio force-pushed the gusinacio/move-ethers-to-alloy branch 5 times, most recently from ab7295d to 05c8533 Compare August 2, 2024 20:31
@gusinacio gusinacio force-pushed the gusinacio/move-ethers-to-alloy branch from 05c8533 to 5b461b8 Compare August 2, 2024 20:34
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 2, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10221721891

Details

  • 34 of 35 (97.14%) changed or added relevant lines in 6 files are covered.
  • 22 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.06%) to 80.83%
Changes Missing Coverage Covered Lines Changed/Added Lines %
tap_aggregator/src/main.rs 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
tap_aggregator/src/metrics.rs 1 0.0%
tap_aggregator/src/main.rs 21 0.0%
Totals Coverage Status
Change from base Build 9689732858: 0.06%
Covered Lines: 915
Relevant Lines: 1132
💛 - Coveralls

@gusinacio gusinacio marked this pull request as ready for review August 2, 2024 20:39
@gusinacio gusinacio requested a review from aasseman as a code owner August 2, 2024 20:39
@gusinacio gusinacio changed the title refactor(all): remove ethers and use alloy refactor(all)!: remove ethers and use alloy Aug 2, 2024
@gusinacio gusinacio changed the title refactor(all)!: remove ethers and use alloy refactor!(all): remove ethers and use alloy Aug 2, 2024
aasseman
aasseman suggested changes Aug 2, 2024
View reviewed changes
Copy link
Contributor

@aasseman aasseman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use an alias for [u8; 65] signatures.
Otherwise LGTM!

@gusinacio gusinacio requested a review from aasseman August 2, 2024 22:28
@aasseman aasseman merged commit b5f2135 into main Aug 2, 2024
8 checks passed
@aasseman aasseman deleted the gusinacio/move-ethers-to-alloy branch August 2, 2024 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aasseman aasseman aasseman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Completely replace ethers with alloy
2 participants
@gusinacio @aasseman