-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[86bye3tve][accordion] added use prop #1474
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilyabrower
reviewed
Jun 28, 2024
ilyabrower
approved these changes
Jul 3, 2024
j-mnizhek
requested changes
Jul 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested some changes in the comment to the PR.
I've fixed it in #1468 |
msereniti
changed the title
[86bye3tve][accordion] added compact mode prop
[86bye3tve][accordion] added use prop
Jul 10, 2024
msereniti
force-pushed
the
accordion-non-compact
branch
from
July 10, 2024 16:29
f51757b
to
46f274c
Compare
j-mnizhek
approved these changes
Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
For a long time our design has both compact and non compact accordions. Alongside react component were not supporting non compact accordion without hacks. This PR adds simple
compact
prop that istrue
by default for backward capability.How has this been tested?
Manually and with VR.
Screenshots (if appropriate):
Types of changes
Checklist:
CHANGELOG.md
file with planned publish date.