Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate org.reflections.reflections from 0.9.12 to 0.10.2 #233

Merged
merged 2 commits into from
Nov 7, 2023

Conversation

RiVogel
Copy link
Contributor

@RiVogel RiVogel commented Nov 6, 2023

This PR updates org.reflections:reflections from 0.9.12 to 0.10.2 since I saw this open issue.
Filtering the resources by prefix and suffix using a regex pattern was possible for both versions, but I also needed to switch from deprecated new ResourcesScanner() to Scanners.Resources for a working solution.

@xtermi2
Copy link
Collaborator

xtermi2 commented Nov 7, 2023

looks like you have to add a null check before MigrationScriptReaderImpl.java:162. Just run the unittests ;)

@RiVogel
Copy link
Contributor Author

RiVogel commented Nov 7, 2023

Damn it, I broke that within cleaning up my code :(

@xtermi2 xtermi2 merged commit 0bc7789 into senacor:master Nov 7, 2023
30 of 32 checks passed
@RiVogel
Copy link
Contributor Author

RiVogel commented Nov 7, 2023

Thanks for merging! What about the failing github action pipeline builds (build-with-macros, release-dry-run)?

@xtermi2
Copy link
Collaborator

xtermi2 commented Nov 7, 2023

  • release-dry-run always fails on "foreign" PRs, because the required gpg key is not accessible from outside.
  • build-with-macros is extremely flakey, it often needs 3-5 retries until it succeeds. I think I will remove it from the pipeline because it doesn't create much added value :/

So no worry, everything is OK :)

@RiVogel
Copy link
Contributor Author

RiVogel commented Nov 7, 2023

Ok, thanks! Are you planning to perform a release soon?

@xtermi2
Copy link
Collaborator

xtermi2 commented Nov 7, 2023

Yes, I hope i find some time until next week.
I also want to update/add compatibility tests with newer Elasticsearch / OpenSearch / SpringBoot / JDK versionons

@xtermi2 xtermi2 linked an issue Nov 14, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dependency update of org.reflections
2 participants