[Snyk] Security upgrade wheel from 0.30.0 to 0.38.0 #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use a thread-safe implementation of cached_property. * Restore setter and deleter. * Restore tests. * Fix __get__ signature for backport. * Cleanup. Co-authored-by: Asif Saif Uddin <[email protected]>
* fixed character replace table according to the comment above - dots replaced by dashes, other punctuations replaced by underscores * optimised with precalculated punctuation set - according to @thedrow suggestion * queue name tests * cleanup
* Update before installing system dependencies. * Actually run the linters using tox. There are no environments named py-flake8, py-pydocstyle and py-apicheck.
it was decided long ago and it let the unit and integrations tests run fast for faster feedback loop
Celery does not coerce configuration values into the right type (See celery/celery#6696). This is a workaround. This bug will be fixed in Celery NextGen when we will refactor our configuration subsystem.
* Make flake8 happy * Make pydocstyle happy
We are ignoring kombu.transport.librabbitmq because apicheck is failing due missing librabbitmq library.
* chore: refactor code quality issues * remove .deepsource.toml config file
This reverts commit 3b6cd13.
* add accept parameter to SimpleQueue class * Fixed missing accept for get_nowait() and added unittests * Remove unused **kwargs from SimpleQueue.__init__ * Use self.consumer.accept instead of new attribute in SimpleQueue * Add tests for simple interface when accept=[] Co-authored-by: Matus Valo <[email protected]>
… KeyError (celery#1343) * Fix broken nested() after celery#1320 * prepare_accept_content now raises SerializerNotInstalled when wrong serializer alias is passed
* Fix broken nested() after celery#1320 * Remove backward compatible code not needed anymore
* Move pytest.importorskip to run earlier
Currently pytest fails to collect tests when `azure` is not present. Moving the pytest.importorskip clause before `from kombu.transport import azureservicebus` fixes it.
```
==================================== ERRORS ====================================
__________ ERROR collecting t/unit/transport/test_azureservicebus.py ___________
ImportError while importing test module '/build/python-kombu/src/kombu-5.1.0/t/unit/transport/test_azureservicebus.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
/usr/lib/python3.9/importlib/__init__.py:127: in import_module
return _bootstrap._gcd_import(name[level:], package, level)
t/unit/transport/test_azureservicebus.py:12: in <module>
from kombu.transport import azureservicebus
kombu/transport/azureservicebus.py:66: in <module>
import azure.core.exceptions
E ModuleNotFoundError: No module named 'azure'
```
* Add # noqa to make linter happy
* feat: add support for setting redis username * tests: add redis connparams credentials tests
* enable pre-commit * use extend-ignore for flake8 * manual flake8 fixes * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Update kombu/__init__.py Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
updates: - [github.com/asottile/pyupgrade: v2.21.2 → v2.23.0](asottile/pyupgrade@v2.21.2...v2.23.0) - https://gitlab.com/pycqa/flake8 → https://github.com/PyCQA/flake8 Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
updates: - [github.com/PyCQA/autoflake: v2.0.1 → v2.0.2](PyCQA/autoflake@v2.0.1...v2.0.2)
* Update azureservicebus.txt cpython only * Update azureservicebus.txt
* Main * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Fix * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Fix * Trigger Build * Fix * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Fix * Fix * noqas * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Fix * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * remove unused noqa * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * re-add import * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Fix * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Fixes * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * use pytest-freezer (celery#1683) * Main * Trigger Build * Fixes * remove * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * lint * Lint --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Asif Saif Uddin <[email protected]>
… found in qos and perform basic_ack (celery#1691) * fix: handle keyerror when message is not found in qos and perform basic_ack * fix: added tests for basic_ack * fix: limit line length
cpython only again
Co-authored-by: semgrep.dev on behalf of @Nusnus <[email protected]>
updates: - [github.com/PyCQA/autoflake: v2.0.2 → v2.1.0](PyCQA/autoflake@v2.0.2...v2.1.0)
* fix mongodb transport obsolete calls + add test mock specs to check valid methods * fix linting
…ery#1621) * Fix celery#1618: avoid re-fetching queue URL when we already have it `_get_from_sqs` was unnecessarily calling `get_queue_url` every time even though the only place which calls `_get_from_sqs` (that is `_get_async`) actually already knows the queue URL. This change avoids hundreds of `GetQueueUrl` AWS API calls per hour when using this SQS backend with celery. Also `connection` is set by the one-and-only caller (and `queue` is actually the queue name string now anyway so couldn't ever have `.connection`) so remove the None default and unused fallback code. * Clarify that `_new_queue` returns the queue URL It seems that prior to 129a9e4 it returned a queue object but this is no longer the case so update comments variable names accordingly to make it clearer. Also remove the incorrect fallback which cannot be correct any more given the return value has to be the queue URL which must be a string. * Unit test coverage for SQS async codepath This key code path (which as far as I can see is the main route when using celery with SQS) was missing test coverage. This test adds coverage for: `_get_bulk_async` -> `_get_async` -> `_get_from_sqs`
* Update redis.txt to 4.3.6 to fix severe issue * Update requirements/extras/redis.txt * Update requirements/extras/redis.txt
The following vulnerabilities are fixed by pinning transitive dependencies: - https://snyk.io/vuln/SNYK-PYTHON-WHEEL-3180413
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Snyk has created this PR to fix one or more vulnerable packages in the `pip` dependencies of this project.
Changes included in this PR
Vulnerabilities that will be fixed
By pinning:
SNYK-PYTHON-WHEEL-3180413
wheel:0.30.0 -> 0.38.0Some vulnerabilities couldn't be fully fixed and so Snyk will still find them when the project is tested again. This may be because the vulnerability existed within more than one direct dependency, but not all of the affected dependencies could be upgraded.
Check the changes in this PR to ensure they won't cause issues with your project.
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
🛠 Adjust project settings
📚 Read more about Snyk's upgrade and patch logic
Learn how to fix vulnerabilities with free interactive lessons:
🦉 Regular Expression Denial of Service (ReDoS)