-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed function signature from rest.API to rest.Send #14
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the README to reflect the new changes: https://github.com/sendgrid/rest/blob/master/README.md
Please update the example code to reflect the changes: https://github.com/sendgrid/rest/blob/master/examples/example.go
rest.go
Outdated
@@ -90,8 +90,8 @@ func BuildResponse(res *http.Response) (*Response, error) { | |||
} | |||
|
|||
// API is the main interface to the API. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update this comment.
rest.go
Outdated
@@ -103,7 +103,7 @@ func (c *Client) MakeRequest(req *http.Request) (*http.Response, error) { | |||
} | |||
|
|||
// API is the main interface to the API. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update this comment
Hello @adnrs96, I think that in order to avoid a breaking change, we should leave With Best Regards, Elmer |
|
This PR changes the function signature from API to Send as raised in issue #13 .
This must be able to resolve issue #13 .