Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed function signature from rest.API to rest.Send #14

Closed
wants to merge 6 commits into from

Conversation

adnrs96
Copy link

@adnrs96 adnrs96 commented Oct 12, 2016

This PR changes the function signature from API to Send as raised in issue #13 .
This must be able to resolve issue #13 .

Copy link
Contributor

@thinkingserious thinkingserious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the README to reflect the new changes: https://github.com/sendgrid/rest/blob/master/README.md

Please update the example code to reflect the changes: https://github.com/sendgrid/rest/blob/master/examples/example.go

rest.go Outdated
@@ -90,8 +90,8 @@ func BuildResponse(res *http.Response) (*Response, error) {
}

// API is the main interface to the API.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update this comment.

rest.go Outdated
@@ -103,7 +103,7 @@ func (c *Client) MakeRequest(req *http.Request) (*http.Response, error) {
}

// API is the main interface to the API.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update this comment

@thinkingserious
Copy link
Contributor

Hi @adnrs96,

This looks great now, thanks!

I will be merging this after we get this one closed.

@thinkingserious thinkingserious added type: community enhancement feature request not on Twilio's roadmap status: cla signed status: work in progress Twilio or the community is in the process of implementing labels Oct 12, 2016
@thinkingserious
Copy link
Contributor

Hello @adnrs96,

I think that in order to avoid a breaking change, we should leave API as a pass through function to Send. Do you mind making that change?

With Best Regards,

Elmer

@SendGridDX
Copy link

SendGridDX commented May 3, 2017

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ thinkingserious
❌ adnrs96
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: work in progress Twilio or the community is in the process of implementing type: community enhancement feature request not on Twilio's roadmap
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants