fix: typings for Client.setDefaultRequest #1383
Open
+9
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
The
ClientRequesttype (alias ofRequestOptions) inClient.setDefaultRequesthas required fieldurl.This means, when using
Client.setDefaultRequest({ httpsAgent: new https.Agent() }), for example, TypeScript will error with fieldurlis missing.This PR makes the type partial, so all fields are optional which reflects the actual behaviour.
Checklist
I have added the necessary documentation about the functionality in the appropriate .md fileI have added inline documentation to the code I modified