Skip to content

chore: update ecdsa in setup.py #1102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 13, 2025
Merged

Conversation

tiwarishubham635
Copy link
Contributor

Fixes #1101

Following up on #1085, adding ecdsa in setup.py as well

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, please file a support ticket.

@tiwarishubham635 tiwarishubham635 merged commit e1ed323 into main May 13, 2025
16 checks passed
@tiwarishubham635 tiwarishubham635 deleted the tiwarishubham635-patch-1 branch May 13, 2025 10:49
@ranjanprasad1996
Copy link
Contributor

ranjanprasad1996 commented May 15, 2025

@shrutiburman @tiwarishubham635 Why do we maintain dependencies in two different files (requirements.txt and setup.py) files? Any reason to keep the same dependencies duplicated in both (can setup.py read the dependencies from the requirements file and use it internally) ?

@tiwarishubham635
Copy link
Contributor Author

Hi @ranjanprasad1996! Setup.py is something which is a must for distributable packages and libraries like ours. Thus it is something which we must have. i don't think it reads from the requirements.txt. I can check for the possibility of omission of the later one. Thanks!

@ranjanprasad1996
Copy link
Contributor

@tiwarishubham635 I understand that it is required for distributable packages. What i am suggesting is having all dependencies in one place (requirements.txt) and setup.py script can read from the file and use it internally

@tiwarishubham635
Copy link
Contributor Author

I totally understand that, let me check if we can do this in some way. Thanks for pointing this out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No module named 'ecdsa' error in latest release
3 participants