feat: cache ptoken

sense-finance · Jul 22, 2024 · 660b967 · 660b967
1 parent 90a84e4
commit 660b967
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/contracts/PointTokenVault.sol b/contracts/PointTokenVault.sol
@@ -249,10 +249,11 @@ contract PointTokenVault is UUPSUpgradeable, AccessControlUpgradeable, Multicall
         }
 
         (string memory name, string memory symbol) = LibString.unpackTwo(_pointsId); // Assume the points id was created using LibString.packTwo.
-        pTokens[_pointsId] = new PToken{salt: _pointsId}(name, symbol, 18);
-        emit PTokenDeployed(_pointsId, address(pTokens[_pointsId]));
+        PToken pToken = new PToken{salt: _pointsId}(name, symbol, 18);
+        pTokens[_pointsId] = pToken;
 
-        return pTokens[_pointsId];
+        emit PTokenDeployed(_pointsId, address(pToken));
+        return pToken;
     }
 
     // Internal ---

diff --git a/contracts/test/PointTokenVault.t.sol b/contracts/test/PointTokenVault.t.sol
@@ -42,6 +42,11 @@ contract PointTokenVaultTest is Test {
 
         pointTokenVault.grantRole(pointTokenVault.DEFAULT_ADMIN_ROLE(), admin);
         pointTokenVault.grantRole(pointTokenVault.MERKLE_UPDATER_ROLE(), merkleUpdater);
+
+
+
+
+
         pointTokenVault.grantRole(pointTokenVault.OPERATOR_ROLE(), operator);
         pointTokenVault.grantRole(pointTokenVault.FEE_COLLECTOR_ROLE(), feeCollector);
         pointTokenVault.revokeRole(pointTokenVault.DEFAULT_ADMIN_ROLE(), address(this));