Merge pull request #19 from sense-finance/feat/convert-rewards-event

feat: add rewards converted event
sense-finance · May 3, 2024 · 7f0f722 · 7f0f722
2 parents c5b2aaf + 99b58a5
commit 7f0f722
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/contracts/PointTokenVault.sol b/contracts/PointTokenVault.sol
@@ -60,6 +60,7 @@ contract PointTokenVault is UUPSUpgradeable, AccessControlUpgradeable, Multicall
     event RootUpdated(bytes32 prevRoot, bytes32 newRoot);
     event PTokensClaimed(address indexed account, bytes32 indexed pointsId, uint256 amount);
     event RewardsClaimed(address indexed owner, address indexed receiver, bytes32 indexed pointsId, uint256 amount);
+    event RewardsConverted(address indexed owner, address indexed receiver, bytes32 indexed pointsId, uint256 amount);
     event RewardRedemptionSet(
         bytes32 indexed pointsId, ERC20 rewardToken, uint256 rewardsPerPToken, bool isMerkleBased
     );
@@ -170,6 +171,8 @@ contract PointTokenVault is UUPSUpgradeable, AccessControlUpgradeable, Multicall
 
         rewardToken.safeTransferFrom(msg.sender, address(this), _amountToConvert);
         pTokens[_pointsId].mint(_receiver, FixedPointMathLib.divWadDown(_amountToConvert, rewardsPerPToken)); // Round down for mint.
+
+        emit RewardsConverted(msg.sender, _receiver, _pointsId, _amountToConvert);
     }
 
     function deployPToken(bytes32 _pointsId) public {

diff --git a/contracts/test/PointTokenVault.t.sol b/contracts/test/PointTokenVault.t.sol
@@ -469,6 +469,8 @@ contract PointTokenVaultTest is Test {
         assertEq(pointTokenVault.pTokens(eigenPointsId).balanceOf(vitalik), 1e18);
     }
 
+    event RewardsConverted(address indexed owner, address indexed receiver, bytes32 indexed pointsId, uint256 amount);
+
     function test_MintPTokensForRewards() public {
         bytes32 root = 0x4e40a10ce33f33a4786960a8bb843fe0e170b651acd83da27abc97176c4bed3c;
 
@@ -497,6 +499,8 @@ contract PointTokenVaultTest is Test {
         vm.prank(vitalik);
         rewardToken.approve(address(pointTokenVault), 1e18);
         vm.prank(vitalik);
+        vm.expectEmit(true, true, true, true);
+        emit RewardsConverted(vitalik, vitalik, eigenPointsId, 1e18);
         pointTokenVault.convertRewardsToPTokens(vitalik, eigenPointsId, 1e18);
 
         assertEq(rewardToken.balanceOf(vitalik), 1e18);