feat: add sender to deposit and withdraw events #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevenvaleri
commented
May 3, 2024
| event Deposit(address indexed receiver, address indexed token, uint256 amount); | ||
| event Withdraw(address indexed user, address indexed token, uint256 amount); | ||
| event Deposit(address indexed depositor, address indexed receiver, address indexed token, uint256 amount); | ||
| event Withdraw(address indexed withdrawer, address indexed receiver, address indexed token, uint256 amount); |
There was a problem hiding this comment.
I don't love "withdrawer" since it's not a word that is too commonly used, but it maps nicely with depositor.
There was a problem hiding this comment.
that is weird how there isn't an obvious complement to depositor but yea seems fine to me
There was a problem hiding this comment.
in 4626 they use "caller" fwiw https://github.com/transmissions11/solmate/blob/c892309933b25c03d32b1b0d674df7ae292ba925/src/tokens/ERC4626.sol#L20
jparklev
approved these changes
May 3, 2024
|
Going to leave as is. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
include the msg.sender in the deposit and withdraw events.
rename the "user" from the withdraw event to the "receiver" to be more consistent
add event tests