Feat/mapping comment update #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jparklev
reviewed
May 8, 2024
Co-authored-by: Josh Levine <[email protected]>
jparklev
approved these changes
May 8, 2024
jparklev
added a commit
that referenced
this pull request
Sep 4, 2024
* Feat/mapping comment update (#18) * feat: update mapping comments * feat: clean comment * Update contracts/PointTokenVault.sol Co-authored-by: Josh Levine <[email protected]> --------- Co-authored-by: Josh Levine <[email protected]> * fix: ensure reward fees are only transferred if the reward token is set, sherlock 185 * fix: correct handling of non-18 decimal reward tokens * fix: revert rewards collection change from different branch * fix: revert rewards collection test change from different branch * fix: correct reversion commit --------- Co-authored-by: Steven Valeri <[email protected]>
jparklev
added a commit
that referenced
this pull request
Sep 4, 2024
…et (#36) * Feat/mapping comment update (#18) * feat: update mapping comments * feat: clean comment * Update contracts/PointTokenVault.sol Co-authored-by: Josh Levine <[email protected]> --------- Co-authored-by: Josh Levine <[email protected]> * fix: ensure reward fees are only transferred if the reward token is set * refactor: don't revert on collect fees if the reward token is unset, just skip the transfer --------- Co-authored-by: Steven Valeri <[email protected]>
jparklev
added a commit
that referenced
this pull request
Sep 4, 2024
* Feat/mapping comment update (#18) * feat: update mapping comments * feat: clean comment * Update contracts/PointTokenVault.sol Co-authored-by: Josh Levine <[email protected]> --------- Co-authored-by: Josh Levine <[email protected]> * chore: trusted claimer -> trusted receiver --------- Co-authored-by: Steven Valeri <[email protected]>
jparklev
added a commit
that referenced
this pull request
Sep 4, 2024
* Feat/mapping comment update (#18) * feat: update mapping comments * feat: clean comment * Update contracts/PointTokenVault.sol Co-authored-by: Josh Levine <[email protected]> --------- Co-authored-by: Josh Levine <[email protected]> * fix: separate deposit cap tracking from contract balance changes * chore: move interaction below effects for deposit --------- Co-authored-by: Steven Valeri <[email protected]>
jparklev
added a commit
that referenced
this pull request
Sep 4, 2024
* Feat/mapping comment update (#18) * feat: update mapping comments * feat: clean comment * Update contracts/PointTokenVault.sol Co-authored-by: Josh Levine <[email protected]> --------- Co-authored-by: Josh Levine <[email protected]> * chore: AGPL --------- Co-authored-by: Steven Valeri <[email protected]>
jparklev
added a commit
that referenced
this pull request
Sep 4, 2024
* Feat/mapping comment update (#18) * feat: update mapping comments * feat: clean comment * Update contracts/PointTokenVault.sol Co-authored-by: Josh Levine <[email protected]> --------- Co-authored-by: Josh Levine <[email protected]> * chore: collect fees after effects --------- Co-authored-by: Steven Valeri <[email protected]>
jparklev
added a commit
that referenced
this pull request
Sep 7, 2024
* fix: correct handling of non-18 decimal reward tokens (#35) * Feat/mapping comment update (#18) * feat: update mapping comments * feat: clean comment * Update contracts/PointTokenVault.sol Co-authored-by: Josh Levine <[email protected]> --------- Co-authored-by: Josh Levine <[email protected]> * fix: ensure reward fees are only transferred if the reward token is set, sherlock 185 * fix: correct handling of non-18 decimal reward tokens * fix: revert rewards collection change from different branch * fix: revert rewards collection test change from different branch * fix: correct reversion commit --------- Co-authored-by: Steven Valeri <[email protected]> * fix: ensure reward fees are only transferred if the reward token is set (#36) * Feat/mapping comment update (#18) * feat: update mapping comments * feat: clean comment * Update contracts/PointTokenVault.sol Co-authored-by: Josh Levine <[email protected]> --------- Co-authored-by: Josh Levine <[email protected]> * fix: ensure reward fees are only transferred if the reward token is set * refactor: don't revert on collect fees if the reward token is unset, just skip the transfer --------- Co-authored-by: Steven Valeri <[email protected]> * chore: trusted claimer -> trusted receiver (#37) * Feat/mapping comment update (#18) * feat: update mapping comments * feat: clean comment * Update contracts/PointTokenVault.sol Co-authored-by: Josh Levine <[email protected]> --------- Co-authored-by: Josh Levine <[email protected]> * chore: trusted claimer -> trusted receiver --------- Co-authored-by: Steven Valeri <[email protected]> * fix: separate deposit cap tracking from contract balance changes (#38) * Feat/mapping comment update (#18) * feat: update mapping comments * feat: clean comment * Update contracts/PointTokenVault.sol Co-authored-by: Josh Levine <[email protected]> --------- Co-authored-by: Josh Levine <[email protected]> * fix: separate deposit cap tracking from contract balance changes * chore: move interaction below effects for deposit --------- Co-authored-by: Steven Valeri <[email protected]> * Chore/agpl (#40) * Feat/mapping comment update (#18) * feat: update mapping comments * feat: clean comment * Update contracts/PointTokenVault.sol Co-authored-by: Josh Levine <[email protected]> --------- Co-authored-by: Josh Levine <[email protected]> * chore: AGPL --------- Co-authored-by: Steven Valeri <[email protected]> * Chore/collect fees after effects (#39) * Feat/mapping comment update (#18) * feat: update mapping comments * feat: clean comment * Update contracts/PointTokenVault.sol Co-authored-by: Josh Levine <[email protected]> --------- Co-authored-by: Josh Levine <[email protected]> * chore: collect fees after effects --------- Co-authored-by: Steven Valeri <[email protected]> * feat: add ExecutionFailed error and improve error handling in execute function (#42) * chore: lock sol version to 0.8.24 (#41) * chore: add comment about not supporting > 18 decimals (#43) --------- Co-authored-by: Steven Valeri <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update comment for clarity