feat: variable rename and clarifying comment #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jparklev
added a commit
that referenced
this pull request
Aug 25, 2024
* feat: make pTokens pausable * feat: add claim trust/delegation function * feat: add pause role, add redemption fee with fee free minter redemptions * chore: tax -> fee * chore: FEE_COLLECTOR -> FEE_COLLECTOR_ROLE * chore: remove unnecessary comment, cleanup fee collection function * Feat/cache ptoken (#21) * feat: cache ptoken * fix: remove extra spaces * feat: update PTokensClaimed event (#23) * feat: combine roles (#22) * feat: combine roles * feat: add _role * feat: add _role to variable * feat: variable rename and clarifying comment (#24) * feat: only set feelessly redeemed if needed (#25) * feat: add fee collector, make fee collection fnc open * feat: add renouncePauseRole function * Feat/set fee collector internal (#26) * feat: setFeeCollector internal with event * feat: add test * fix: add whenNotPaused to pToken mint and burn --------- Co-authored-by: Steven Valeri <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pTokensToFee -> redeemableWithFee and accumulator in comment