Refactor ARView: Remove extraneous UI and load glTF model from public directory #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
georgi-s
commented
Apr 7, 2025
georgi-s
commented
- Removed all unnecessary UI overlays, loading messages, and buttons from ARView.
- Simplified the AR session logic to auto-start based on detected AR capability.
- Updated the modelPath to use a relative URL (e.g., /gltf/bike/senseBox_bike.gltf) from the public folder.
- Cleaned up unused variables to ensure a streamlined AR experience.
… directory - Removed all unnecessary UI overlays, loading messages, and buttons from ARView. - Simplified the AR session logic to auto-start based on detected AR capability. - Updated the modelPath to use a relative URL (e.g., /gltf/bike/senseBox_bike.gltf) from the public folder. - Cleaned up unused variables to ensure a streamlined AR experience.
✅ Deploy Preview for sensebox-3d ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
felixerdy
requested changes
Apr 7, 2025
| label: string; | ||
| } | ||
|
|
||
| export default function FloatingButton({ |
There was a problem hiding this comment.
please make the button a little bit more subtle
- remove the shadown waves
- make button a little bit wider
| import * as THREE from "three"; | ||
| import { GLTFLoader } from "three/addons/loaders/GLTFLoader.js"; | ||
|
|
||
| function detectARCapability() { |
There was a problem hiding this comment.
please try not to show the AR button on desktop since they dont support AR (tested on macOS with chrome)
public/BikeBox_Mini_S2_v101_v5.usdz
Outdated
There was a problem hiding this comment.
please apply the following changes:
- remove the ultrasonic distance sensor mount (only using the tof one)
- make display black / dark grey
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.