-
Notifications
You must be signed in to change notification settings - Fork 420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a Docker container for dot #95
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
one suggestion: maybe we can create an account on docker hub and push some docker images for users to pull instead of building it locally?
i believe this removes the need to manually download model weights before building the docker image.
In the Dockerfile Im adding the step to download the weights. So they don't need to be manually downloaded |
cool! |
to be tested on ubuntu before merging |
get we get it tested on all platform before merging? @Ghassen-Chaabouni @vassilispapadop |
status before merge: it works on windows and ubuntu; we will open an issue for mac osx |
Description
Add Docker to dot.
Fixes #10
Changelog:
Added:
Dockerfile
anddocker-compose.yml
Updated:
README.md
reverse2original.py