Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a Docker container for dot #95

Merged
merged 15 commits into from
Oct 11, 2023
Merged

Add a Docker container for dot #95

merged 15 commits into from
Oct 11, 2023

Conversation

Ghassen-Chaabouni
Copy link
Contributor

@Ghassen-Chaabouni Ghassen-Chaabouni commented Jul 24, 2023

Description

Add Docker to dot.

Fixes #10

Changelog:

Added:

  • Dockerfile and docker-compose.yml

Updated:

  • Docker instructions in README.md
  • Remove cupy in reverse2original.py

@Ghassen-Chaabouni Ghassen-Chaabouni added the docker Issues or pull requests related to docker support label Jul 24, 2023
@Ghassen-Chaabouni Ghassen-Chaabouni self-assigned this Jul 24, 2023
README.md Show resolved Hide resolved
@Ghassen-Chaabouni Ghassen-Chaabouni marked this pull request as draft September 22, 2023 12:40
@Ghassen-Chaabouni Ghassen-Chaabouni marked this pull request as ready for review September 25, 2023 09:50
Copy link
Member

@ajndkr ajndkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

one suggestion: maybe we can create an account on docker hub and push some docker images for users to pull instead of building it locally?

i believe this removes the need to manually download model weights before building the docker image.

@Ghassen-Chaabouni
Copy link
Contributor Author

lgtm

one suggestion: maybe we can create an account on docker hub and push some docker images for users to pull instead of building it locally?

i believe this removes the need to manually download model weights before building the docker image.

In the Dockerfile Im adding the step to download the weights. So they don't need to be manually downloaded

@ajndkr
Copy link
Member

ajndkr commented Sep 25, 2023

lgtm
one suggestion: maybe we can create an account on docker hub and push some docker images for users to pull instead of building it locally?
i believe this removes the need to manually download model weights before building the docker image.

In the Dockerfile Im adding the step to download the weights. So they don't need to be manually downloaded

cool!

@giorgiop
Copy link
Member

to be tested on ubuntu before merging

@giorgiop
Copy link
Member

giorgiop commented Oct 3, 2023

get we get it tested on all platform before merging? @Ghassen-Chaabouni @vassilispapadop

@Ghassen-Chaabouni Ghassen-Chaabouni merged commit c277290 into main Oct 11, 2023
2 checks passed
@Ghassen-Chaabouni Ghassen-Chaabouni deleted the Add-docker branch October 11, 2023 11:46
@giorgiop
Copy link
Member

status before merge: it works on windows and ubuntu; we will open an issue for mac osx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docker Issues or pull requests related to docker support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Run dot with docker
3 participants