[CVE-2017-8418] - updating rubocop dependency. #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Close security vulnerability by updating rubocop dependency.
removed ruby < 2.1 support and testing:
```
Bundler could not find compatible versions for gem "ruby":
In Gemfile:
ruby
bundler (~> 1.7) was resolved to 1.16.0, which depends on
ruby (>= 1.8.7)
pry (~> 0.10) was resolved to 0.11.3, which depends on
ruby (>= 1.9.3)
rubocop (~> 0.51.0) was resolved to 0.51.0, which depends on
ruby (>= 2.1.0)
sensu-plugins-ansible was resolved to 1.0.0, which depends on
ruby (>= 2.0.0)
```
changelog location updates
Signed-off-by: Ben Abrams <[email protected]>
majormoses
force-pushed
the
fix/CVE-2017-8418
branch
from
1a8f4df to
3d7ac69
Compare
see: rubocop/rubocop#4767 for more info Signed-off-by: Ben Abrams <[email protected]>
eheydrick
approved these changes
Nov 21, 2017
|
We should update the version in the skel so that new plugins get the newer rubocop out of the gate. |
|
Double checked and it is locked at |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close security vulnerability by updating rubocop dependency.
removed ruby < 2.1 support and testing:
changelog location updates
Signed-off-by: Ben Abrams [email protected]
Pull Request Checklist
sensu-plugins/community#77
General
Update Changelog following the conventions laid out on Keep A Changelog
Update README with any necessary configuration snippets
Binstubs are created if needed
RuboCop passes
Existing tests pass
Purpose
Resolve CVE (see parent issue for details)
Known Compatibility Issues
Requires ruby 2.1 or greater