[CVE-2017-8418] - updating rubocop dependency. #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
majormoses
force-pushed
the
fix/CVE-2017-8418
branch
from
faa9461 to
0f13f19
Compare
majormoses
force-pushed
the
fix/CVE-2017-8418
branch
from
0f13f19 to
6389ae9
Compare
Misc: - appeasing the cops where time allowed, created TODOs to come back later and refactor. Signed-off-by: Ben Abrams <[email protected]>
majormoses
force-pushed
the
fix/CVE-2017-8418
branch
from
6389ae9 to
07ed7bf
Compare
reverted the annotations, disabled the rule for those lines matching cops, and added TODO to look at a later date. Signed-off-by: Ben Abrams <[email protected]>
thomasriley
approved these changes
Jan 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Misc:
Signed-off-by: Ben Abrams [email protected]
Pull Request Checklist
sensu-plugins/community#77
General
Update Changelog following the conventions laid out here
Update README with any necessary configuration snippets
Binstubs are created if needed
RuboCop passes
Existing tests pass
Purpose
Resolve CVE (see parent issue for details)
Known Compatibility Issues
None I hope, it was quite large...