Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CVE-2017-8418] Update ruby plugins for vulnerable rubocop dependency #2

Merged
merged 1 commit into from
Feb 1, 2018

Conversation

majormoses
Copy link
Member

@majormoses majormoses commented Dec 28, 2017

Misc:

  • Had to drop ruby < 2.1 support to bring in new dep
  • changelog guidelines location

Signed-off-by: Ben Abrams [email protected]

Pull Request Checklist

sensu-plugins/community#77

General

  • Update Changelog following the conventions laid out on Keep A Changelog

  • Update README with any necessary configuration snippets

  • Binstubs are created if needed

  • RuboCop passes

  • Existing tests pass

Purpose

Address minor CVE with rubocop

Known Compatibility Issues

Drops ruby 2.0 support.

Misc:
- Had to drop ruby < 2.1 support to bring in new dep
- changelog guidelines location

Signed-off-by: Ben Abrams <[email protected]>
Copy link
Member

@jaredledvina jaredledvina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@majormoses majormoses merged commit 8173dc7 into master Feb 1, 2018
@majormoses
Copy link
Member Author

Sorry for the spam I keep copying the wrong ones while I am waiting to confirm the rubygems existence (seems like a cashing issue and have been working on others).

@majormoses
Copy link
Member Author

caching issue is resolved.

released: https://rubygems.org/gems/sensu-plugins-bigpanda/versions/1.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants