[CVE-2017-8418] - updating rubocop dependency. #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Misc Chanages: - appeased the cops - update changelog guidelines location Breaking Changes: - removed ruby < 2.1 support and testing to satisfy rubocop depenency. Signed-off-by: Ben Abrams <[email protected]>
majormoses
force-pushed
the
fix/CVE-2017-8418
branch
from
b6b1ba0 to
a2a9280
Compare
eheydrick
approved these changes
Jan 19, 2018
|
LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Misc Chanages:
Signed-off-by: Ben Abrams [email protected]
Pull Request Checklist
sensu-plugins/community#77
General
Update Changelog following the conventions laid out on Keep A Changelog
Update README with any necessary configuration snippets
Binstubs are created if needed
RuboCop passes
Existing tests pass
Purpose
Address minor CVE with rubocop
Known Compatibility Issues
Removed ruby < 2.1 support.