added basic metrics #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I found the issue: https://github.com/sensu-plugins/sensu-plugins-kafka/blob/d1d603b7ae5cb14daf9dc0f2b5f738aa9b3b1df4/Rakefile#L33 it needs to be updated I will push to your fork and make sure the tests pass. Sorry about the delay and my lack of noticing it earlier. |
|
@yuri-zubov can you please add a changelog entry for the new checks? |
majormoses
reviewed
May 2, 2018
| require 'zookeeper' | ||
|
|
||
| class TopicsCheck < Sensu::Plugin::Check::CLI | ||
| option :zookeeper, |
There was a problem hiding this comment.
I have not really looked into kafka can you confirm this makes sense to live here and not in the zookeeper plugin?
There was a problem hiding this comment.
@majormoses
It complements the zookeeper plugin
Which I've also tested
Provides more Kafka-specifics checks
Especially the one relying on the HTTP servlet
Which actually exposés Dropwizard metrics, not available through zookeeper
majormoses
requested changes
May 2, 2018
bin/check-topic.rb
Outdated
| description: 'Topic name', | ||
| short: '-n TOPIC_NAME', | ||
| long: '--name TOPIC_NAME', | ||
| required: true |
There was a problem hiding this comment.
either align with the others or use a single space here.
| require 'zookeeper' | ||
|
|
||
| class TopicsCheck < Sensu::Plugin::Check::CLI | ||
| option :zookeeper, |
There was a problem hiding this comment.
same question about if this is the right place for this check or if it should live in the zookeeper plugin.
|
@majormoses I see that name |
|
test artifact |
|
Hmm the failure is completely unreleased but I see that and will reach out about transfering over to the community. |
|
looks like it minimally needs a compiler to install: https://travis-ci.org/sensu-plugins/sensu-plugins-kafka/jobs/373837587#L1042 I will see if I can get it working for you. |
majormoses
approved these changes
May 3, 2018
|
I am gonna hold off on releasing this as I want to see what happens obazoud/sensu-plugins-kafka#21 before doing something like renaming to |
|
Please ping me if we do not get a response in a bit and I will go down the path of renaming the plugin to avoid namespace collision. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Is this in reference to an existing issue?
General
Update Changelog following the conventions laid out here
Update README with any necessary configuration snippets
Binstubs are created if needed
RuboCop passes
Existing tests pass
New Plugins
Tests
Add the plugin to the README
Does it have a complete header as outlined here
Purpose
Known Compatibility Issues