Feature/equal to

[derekgroh]

Pull Request Checklist

#101

General

• Update Changelog following the conventions laid out on Our CHANGELOG Guidelines

• Update README with any necessary configuration snippets

• Binstubs are created if needed

• RuboCop passes

• Existing tests pass

Purpose

Match the operator logic around cpu and memory checks as found in their Linux counterparts. Use greater than or equal to instead of greater than.

Known Compatibility Issues

None

[majormoses]

LGTM

Needs changelog section header.

[majormoses]

It's important to note that this change while unlikely will negatively affect someone some people may be very specific and this breaks their old expectations.

Suggested change

	- update cpu and memory checks to follow comparison operator in linux plugins check (greater than or equal to) (@derekgroh)
	### [Breaking Changes]
	- update cpu and memory checks to follow comparison operator in linux plugins check (greater than or equal to) (@derekgroh)

[derekgroh]

A noteworthy change, but this is not breaking by definition.

[majormoses]

It depends on how you define breaking. It absolutely changes the expectation of the outcome what will happen given the same input. Even though its a good call it is absolutely breaking. It does not matter if it affects 1 or millions of users, breaking is breaking. It's the only way semver can be trusted. When in doubt version major, it will save you later when someone complains about you breaking their particular edgecase you never thought about.

Take for example:

# use the same value as input
current_value = 50

# testing old behavior would result in an OK
if current_value > 50
  critical
else
  ok
end

# testing new behavior will result in a CRITICAL
if current_value >= 50
  critical
else
  ok
end