Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config no longer falsely loads profiles if file doesn't exist #486

Merged
merged 2 commits into from
Nov 3, 2023

Conversation

zigaLuksic
Copy link
Collaborator

As noticed by you, if the file doesn't exist one could do the first initialization with SHConfig("something") and break the whole damn thing.

I added a test that now the first init fails for any non-default profile (since no such profile exists).

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3c4501c) 91.93% compared to head (3c4501c) 91.93%.

❗ Current head 3c4501c differs from pull request most recent head 8e4cc4f. Consider uploading reports for the commit 8e4cc4f to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #486   +/-   ##
========================================
  Coverage    91.93%   91.93%           
========================================
  Files           55       55           
  Lines         4800     4800           
========================================
  Hits          4413     4413           
  Misses         387      387           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jonasViehweger
Copy link
Contributor

Looks good, thanks for fixing

@zigaLuksic zigaLuksic merged commit b8c96e9 into develop Nov 3, 2023
7 checks passed
@zigaLuksic zigaLuksic deleted the config-init branch November 3, 2023 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants