Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sh-config CLI use environmental variable #487

Merged
merged 3 commits into from
Nov 3, 2023
Merged

Make sh-config CLI use environmental variable #487

merged 3 commits into from
Nov 3, 2023

Conversation

zigaLuksic
Copy link
Collaborator

@zigaLuksic zigaLuksic commented Nov 2, 2023 •
edited
Loading

the saving is also unnecessary because the load method creates the file if needed

saving is needed because we have one do-all command. Gotta figure this out

@zigaLuksic zigaLuksic requested a review from mlubej November 2, 2023 12:51
mlubej
mlubej approved these changes Nov 2, 2023
View reviewed changes
Copy link
Contributor

@mlubej mlubej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirming it works now. Really shows what a good refactor can do, a really elegant fix.

@zigaLuksic zigaLuksic merged commit 3c4501c into develop Nov 3, 2023
7 checks passed
@zigaLuksic zigaLuksic deleted the sh-config-cli-fix branch November 3, 2023 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mlubej mlubej mlubej approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zigaLuksic @mlubej