Update #1
Open
Update #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…enu (e.g. ip addess)
The existing regexp to Linux interface names with VLANs (e.g. eth0.10) fails with the new style predictable device names (e.g. enp0s20f2.10), causing fwbuilder to reject the interface name. This makes it impossible to build firewall configurations on recent distributions without disabling predictable device naming. Update regexp to allow matching of newer style device names
Update interface pattern for VLANs with predictable device naming
adding AddressRangeIPv6
This reverts commit 276f9ef.
…enu (e.g. ip addess)
The string "debug1: key_parse_private_pem: PEM_read_PrivateKey failed" should not be match the rexex for shell errors. Fixes #58
If needed on MSVC, use code from https://www.codeproject.com/Articles/157001/Full-getopt-Port-for-Unicode-and-Multibyte-Microso
Install manpages in the system's manpage folder instead of using CMAKE_INSTALL_DATADIR. This allows to respect manpage hierarchy on any OS.
Some systems, like OpenBSD for example, have libdl integrated in libc. Let CMAKE_DL_LIBS decide if '-ldl' is needed as a linker flag
OpenBSD: requires <sys/stat.h> for stat(2)
Use ${CMAKE_DL_LIBS} for portability
Use CMAKE_INSTALL_MANDIR
Create start menu entries for all users.
Error "Firewall Builder: Unknown option 'n'." when opening files on Windows using double-click.
Delay usage of C++17 to after 6.0, as there's no current usage, but staying on C++11 will support Ubuntu 16.04 LTS. This reverts commit 3359246.
Dark theme is usable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.