Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for returning scheduled job date time #187

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

StephenOTT
Copy link

Related to: #60

Other related pull request in qless-core: seomoz/qless-core#48

@StephenOTT
Copy link
Author

  • Add support for checking a jobs original scheduled date and processed/completion date for a job that has been completed.

@@ -43,7 +43,7 @@ class Job < BaseJob
attr_reader :jid, :expires_at, :state, :queue_name, :worker_name, :failure
attr_reader :klass_name, :tracked, :dependencies, :dependents
attr_reader :original_retries, :retries_left, :raw_queue_history
attr_reader :state_changed
attr_reader :state_changed, :scheduleddate
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

scheduleddate should be scheduled_date by convention

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. The entire way scheduleddate is calculated and presented needs to be adjusted. Have been using it in prod and finding a few gaps and expected features that were missed first round

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants