make more distinct color of disabled buttons #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you post before/after screen shots? It's not clear to me what buttons need a more distinct color. Also, this is one that I suspect @danlecocq will want to sign off on since the qless UI provided by the gem is used by other teams/projects using non-ruby bindings. It'd also be nice to avoid changing the bootstrap css files to facilitate the possibility of updating the bootstrap files in the future w/o losing your changes. |
|
+1 on before/after screen shots |
|
💯 on screeenshots. And thanks go to @myronmarston who taught me how to do that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.