Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle failure in starting subscribers more gracefully #280

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

oggy
Copy link
Contributor

@oggy oggy commented Nov 30, 2018

If one subscriber failed to start, subscribers here was left
undefined. This ensures that subscribers which did succeed are stopped,
in addition to handling the NoMethodError.

If one subscriber failed to start, `subscribers` here was left
undefined. This ensures that subscribers which did succeed are stopped,
in addition to handling the `NoMethodError`.
Copy link
Contributor

@dlecocq dlecocq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Travis failure appears transient, and I like the change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants