Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat] 수신자 지정 api 구현 #53

Merged
merged 3 commits into from
Dec 21, 2024
Merged

[Feat] 수신자 지정 api 구현 #53

merged 3 commits into from
Dec 21, 2024

Conversation

KyunghwanChoi
Copy link
Collaborator

Related issue 🛠

Work Description ✏️

이메일 수신자 지정 api 구현

Trouble Shooting ⚽️

Related ScreenShot 📷

image

Uncompleted Tasks 😅

To Reviewers 📢

@KyunghwanChoi
Copy link
Collaborator Author

image

이메일 입력하지 않았을 경우 (blank)

@KyunghwanChoi
Copy link
Collaborator Author

image 잘못된 형식의 이메일이거나, 해당 이메일의 회원이 존재하지 않을 경우

Copy link
Owner

@seoshinehyo seoshinehyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다! 커멘트 한 번만 확인해주세요!

IMAGE_UPLOAD_FAILED(HttpStatus.INTERNAL_SERVER_ERROR, "IMAGE5001", "이미지 업로드에 실패했습니다.");
IMAGE_UPLOAD_FAILED(HttpStatus.INTERNAL_SERVER_ERROR, "IMAGE5001", "이미지 업로드에 실패했습니다."),

EMAIL_MEMBER_NOT_FOUND(HttpStatus.BAD_REQUEST, "MEMBER404", "해당 이메일의 회원을 찾을 수 없습니다.");
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

기존에 작성되어있는 MEMBER_NOT_FOUND를 사용하지 않고, 다른 변수를 추가해서 사용한 이유가 무엇일까요??

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image MEMBER_NOT_FOUND와 출력 메세지가 달라서 따로 정의했습니다! 혹시 문제되는 부분일까요?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

의도하신 거라면 문제 없습니다! 기존 변수를 못 찾고 새로 만든 줄 알았습니다. 고생하셨습니다!

@seoshinehyo seoshinehyo merged commit 17c0edf into develop Dec 21, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Fix] 수신자 지정 예외처리 수정 [Feat] 수신자 지정 구현
2 participants