Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor #158

Merged
merged 8 commits into from
Jan 13, 2024
Merged

Refactor #158

merged 8 commits into from
Jan 13, 2024

Conversation

sepandhaghighi
Copy link
Owner

Reference Issues/PRs

What does this implement/fix? Explain your changes.

  • edge_number param removed from generator functions
  • autopep8.bat updated

Any other comments?

@sepandhaghighi sepandhaghighi added this to the pyrgg 1.5 milestone Jan 11, 2024
@sepandhaghighi sepandhaghighi self-assigned this Jan 11, 2024
Copy link

codecov bot commented Jan 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e2f1bbb) 98.50% compared to head (d064fb3) 98.50%.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #158   +/-   ##
=======================================
  Coverage   98.50%   98.50%           
=======================================
  Files           4        4           
  Lines         464      464           
  Branches       76       76           
=======================================
  Hits          457      457           
  Misses          4        4           
  Partials        3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sepandhaghighi sepandhaghighi marked this pull request as ready for review January 12, 2024 22:52
Copy link
Collaborator

@sadrasabouri sadrasabouri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your effort. Also thank you for updating tests for branch_gen. The ignore flag caused me to forget updating it.

@sadrasabouri sadrasabouri merged commit 4d73c0d into dev Jan 13, 2024
52 checks passed
@sadrasabouri sadrasabouri deleted the refactor branch January 13, 2024 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants