Engines Modularized #160
Merged
Engines Modularized #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… moved to `pyrgg` engine.
…ck to `function.py`.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #160 +/- ##
==========================================
+ Coverage 98.57% 98.61% +0.05%
==========================================
Files 4 7 +3
Lines 487 502 +15
Branches 82 82
==========================================
+ Hits 480 495 +15
Misses 4 4
Partials 3 3 ☔ View full report in Codecov by Sentry. |
sepandhaghighi
requested changes
Mar 25, 2024
There was a problem hiding this comment.
@sadrasabouri Thanks for your efforts 🥇
Please take a look at my comments 🔥
|
@sepandhaghighi It's ready for your review Sepand. |
sepandhaghighi
requested changes
Apr 16, 2024
There was a problem hiding this comment.
@sadrasabouri Please take a look at my comments. I noticed some variable names that seem to be misspelled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
#145
What does this implement/fix? Explain your changes.
There were some necessary changes regarding engine modularization. Now different engines by same interface is accessible through
pyrgg.engines. Also tests separated for different modules.