Skip to content

Conversation

vitalis89
Copy link

If key is not in result, then there's no point in trying to delete it anyway

seperman and others added 7 commits August 8, 2025 11:58
- Add validation to prevent traversing dunder attributes via check_elem()
- Harden Delta class against malicious pickle payloads
- Make SAFE_TO_IMPORT a frozenset for immutability
- Add comprehensive security tests in test_security.py
- Prevent access to __globals__ and other dangerous attributes
- Update version to 8.6.1 across all files
- Add security vulnerability notes to CHANGELOG and README
- Update AUTHORS.md to credit security reporter
- Update documentation with security fix information
adding security tests and a patch for the class pollution and remote code execution
If `key` is not in result, then there's no point in trying to delete it anyway
@seperman seperman changed the base branch from master to dev October 13, 2025 05:46
@seperman
Copy link
Owner

Hi @vitalis89

  1. Please merge our dev branch back to your branch and push again since the PR is showing other non-relevant stuff that were already on the master branch when you started working on this.
  2. I am not following your logic. ignore_keys is typically much smaller than __dict__ so it is a performance hit to do for key in obj.__dict__:. Not sure what we are gaining by this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants