-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jump lists app names #2280
base: master
Are you sure you want to change the base?
Jump lists app names #2280
Conversation
CustomDestinations files.
Custom Destinations to expand by default.
to Windows Artifacts.
Thank you @patrickdalla, this can be very useful! Seems to me #2278 has 4 identical commits to this PR. Should #2278 be closed without merging? By the way, ideally I think the new categories should be prepared for translation. |
Hi Nassif, But I refactored the JS to be ES5 compatible and if you approve the way it is implemented PR2280 can be merged and 2278 skipped and closed. I will just finish the localization right now. |
Destinations categories.
ready. If you think JS task approach is not the best way to implement this app id name resolution you can skip this pr and merge 2278. |
Thank you @patrickdalla! Using a javascript task is fine. |
Identify Jumplist app name based on know list of IDs.
I put this in DRAFT because I used back tick to declare a var from a multiline literal (the list of know apps).
It worked only when adding "-Dnashorn.args=--language=es6". But this can affect other modules.
So, if it do affect any other modules, I will have to change it and declare this list in other way.