Skip to content

Commit

Permalink
Merge pull request #34 from mbrossard/master
Browse files Browse the repository at this point in the history
Fix for trailing line-feed on signature (fixes #33)
  • Loading branch information
mbrossard committed Nov 3, 2015
2 parents e3d8956 + 145b7f2 commit 90e64ec
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 2 deletions.
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
NAME = yum-plugin-s3-iam
VERSION = 1.0
VERSION = 1.0.1

This comment has been minimized.

Copy link
@revmischa

revmischa Nov 3, 2015

Collaborator

increment RELEASE imo; that is what it is for

This comment has been minimized.

Copy link
@mbrossard

mbrossard Nov 3, 2015

Author Collaborator

RELEASE is for package release, i.e. the number of times the package has been rebuilt using the same version of the software (source Wikipedia or rpm.org)

This comment has been minimized.

Copy link
@revmischa

revmischa Nov 3, 2015

Collaborator

yeah and it's going to get rebuilt here... since it's tracked in version control it wouldn't be a bad idea to increment it. my only point was that adding a point version to VERSION is silly when you have RELEASE. Either bump VERSION or RELEASE but don't add another minor point to VERSION lol. That's all. Minor quibble.

RELEASE = 1
ARCH = noarch

Expand Down
2 changes: 1 addition & 1 deletion s3iam.py
Original file line number Diff line number Diff line change
Expand Up @@ -259,4 +259,4 @@ def sign(self, request, timeval=None):
str(sigstring),
hashlib.sha1).digest()
signature = digest.encode('base64')
return signature
return signature.strip()
3 changes: 3 additions & 0 deletions yum-plugin-s3-iam.spec
Original file line number Diff line number Diff line change
Expand Up @@ -37,5 +37,8 @@ rm -rf ${RPM_BUILD_ROOT}
/usr/lib/yum-plugins/s3iam.py*

%changelog
* Mon Sep 21 2015 Mathias Brossard <[email protected]> 1.0.1-1
Fix for trailing line-feed on signature

* Fri May 31 2013 Matt Jamison <[email protected]> 1.0-1
Initial packaging

1 comment on commit 90e64ec

@revmischa
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Praise jesus

Please sign in to comment.