[INFRA] add enable_testing

was actually missing for performance tests before
seqan · Nov 8, 2023 · 1e40828 · 1e40828
1 parent 8122c1c
commit 1e40828
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 5 deletions.
diff --git a/.github/workflows/ci_misc.yml b/.github/workflows/ci_misc.yml
@@ -89,7 +89,6 @@ jobs:
           cmake ../test/${{ matrix.build }} -DCMAKE_BUILD_TYPE=${{ matrix.build_type }} \
                                             -DHIBF_NATIVE_BUILD=OFF \
                                             -DHIBF_VERBOSE_TESTS=OFF \
-                                            -DHIBF_BENCHMARK_MIN_TIME=0.01 \
                                             -DHIBF_USE_INCLUDE_DEPENDENCIES="${{ matrix.use_include_dependencies }}"
           case "${{ matrix.build }}" in
             unit) make -j2 gtest_main;;

diff --git a/test/hibf-test.cmake b/test/hibf-test.cmake
@@ -36,6 +36,8 @@ list (APPEND CMAKE_MODULE_PATH "${HIBF_TEST_CMAKE_MODULE_DIR}")
 # Interface targets for the different test modules in hibf.
 # ----------------------------------------------------------------------------
 
+enable_testing ()
+
 # hibf::test exposes a base set of required flags, includes, definitions and
 # libraries which are in common for **all** hibf tests
 if (NOT TARGET hibf::test)

diff --git a/test/performance/CMakeLists.txt b/test/performance/CMakeLists.txt
@@ -8,7 +8,7 @@ project (hibf_test_performance CXX)
 include (../hibf-test.cmake)
 
 set (HIBF_BENCHMARK_MIN_TIME
-     "1"
+     "0.01s"
      CACHE STRING "Set --benchmark_min_time= for each bechmark. Timings are unreliable in CI.")
 
 macro (hibf_benchmark benchmark_cpp)

diff --git a/test/performance/ibf/interleaved_bloom_filter_benchmark.cpp b/test/performance/ibf/interleaved_bloom_filter_benchmark.cpp
@@ -30,9 +30,9 @@ static void arguments(benchmark::internal::Benchmark * b)
     // Total size: 1MiB
     // bins, bin_size, hash_num, sequence_length
     b->Args({64, 1LL << 17, 2, 1LL << 17});
-    b->Args({128, 1LL << 16, 2, 1LL << 17});
-    b->Args({192, 1LL << 16, 2, 1LL << 17});
-    b->Args({256, 1LL << 15, 2, 1LL << 17});
+    // b->Args({128, 1LL << 16, 2, 1LL << 17});
+    // b->Args({192, 1LL << 16, 2, 1LL << 17});
+    // b->Args({256, 1LL << 15, 2, 1LL << 17});
     // b->Args({320, 1LL << 15, 2, 1LL << 17});
     // b->Args({384, 1LL << 14, 2, 1LL << 17});
     // b->Args({448, 1LL << 14, 2, 1LL << 17});