Skip to content

Commit

Permalink
Merge pull request #125 from eseiler/infra/update_contrib
Browse files Browse the repository at this point in the history
[INFRA] Update contrib/std
  • Loading branch information
eseiler authored Oct 11, 2023
2 parents 1232199 + 01f6484 commit 9f4bd53
Show file tree
Hide file tree
Showing 4 changed files with 20 additions and 6 deletions.
13 changes: 13 additions & 0 deletions include/hibf/contrib/README.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
The `std` directory is a git subtree and includes the content of https://github.com/seqan/seqan-std.

For a general overview regarding `git subtree`, see, for example, https://www.atlassian.com/git/tutorials/git-subtree.

Pulling upstream changes can be achieved by
```
git subtree pull --prefix include/hibf/contrib/std https://github.com/seqan/seqan-std.git main --squash
```

Similarly, you can push subtree changes to your fork:
```
git subtree push --prefix include/hibf/contrib/std https://github.com/<user>/seqan-std.git <branch>
```
6 changes: 3 additions & 3 deletions include/hibf/contrib/std/chunk_view.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,7 @@ class chunk_view<V>::outer_iterator
return *x.parent_->current_ == std::ranges::end(x.parent_->base_) && x.parent_->remainder_ != 0;
}

friend constexpr difference_type operator-(std::default_sentinel_t y, outer_iterator const & x)
friend constexpr difference_type operator-(std::default_sentinel_t, outer_iterator const & x)
requires std::sized_sentinel_for<std::ranges::sentinel_t<V>, std::ranges::iterator_t<V>>
{
auto const dist = std::ranges::end(x.parent_->base_) - *x.parent_->current_;
Expand Down Expand Up @@ -270,7 +270,7 @@ class chunk_view<V>::inner_iterator
return x.parent_->remainder_ == 0;
}

friend constexpr difference_type operator-(std::default_sentinel_t y, inner_iterator const & x)
friend constexpr difference_type operator-(std::default_sentinel_t, inner_iterator const & x)
requires std::sized_sentinel_for<std::ranges::sentinel_t<V>, std::ranges::iterator_t<V>>
{
std::ranges::min(x.parent_->remainder_, std::ranges::end(x.parent_->base_) - *x.parent_->current_);
Expand Down Expand Up @@ -572,7 +572,7 @@ class chunk_view<V>::iterator
return (x.current_ - y.current_ + x.missing_ - y.missing_) / x.n_;
}

friend constexpr difference_type operator-(std::default_sentinel_t y, iterator const & x)
friend constexpr difference_type operator-(std::default_sentinel_t, iterator const & x)
requires std::sized_sentinel_for<std::ranges::sentinel_t<Base>, std::ranges::iterator_t<Base>>
{
return seqan::stl::detail::chunk::div_ceil(x.end_ - x.current_, x.n_);
Expand Down
4 changes: 2 additions & 2 deletions include/hibf/contrib/std/join_with_view.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -88,10 +88,10 @@ class join_with_view :
Pattern pattern_{};

template <bool Const>
struct iterator;
class iterator;

template <bool Const>
struct sentinel;
class sentinel;

public:
join_with_view()
Expand Down
3 changes: 2 additions & 1 deletion include/hibf/contrib/std/zip_view.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,8 @@

#include <ranges>

#ifdef __cpp_lib_ranges_zip
// https://godbolt.org/z/YW7e785sd
#if defined __cpp_lib_ranges_zip && !defined(__clang__)

namespace seqan::stl::views
{
Expand Down

1 comment on commit 9f4bd53

@vercel
Copy link

@vercel vercel bot commented on 9f4bd53 Oct 11, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Successfully deployed to the following URLs:

hibf – ./

hibf.vercel.app
hibf-seqan.vercel.app
hibf-git-main-seqan.vercel.app

Please sign in to comment.