Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Layout backtracking needs union estimation to find correct max bin #126

Merged
merged 2 commits into from
Oct 12, 2023

Conversation

smehringer
Copy link
Member

No description provided.

@vercel
Copy link

vercel bot commented Oct 11, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hibf ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 12, 2023 10:24am

@seqan-actions seqan-actions added lint [INTERNAL] used for linting and removed lint [INTERNAL] used for linting labels Oct 11, 2023
@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (4732ff1) 100.00% compared to head (1b4e2f5) 99.71%.

Additional details and impacted files
@@             Coverage Diff             @@
##              main     #126      +/-   ##
===========================================
- Coverage   100.00%   99.71%   -0.29%     
===========================================
  Files           39       39              
  Lines         1397     1408      +11     
===========================================
+ Hits          1397     1404       +7     
- Misses           0        4       +4     
Files Coverage Δ
src/layout/hierarchical_binning.cpp 97.77% <66.66%> (-2.23%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@smehringer smehringer enabled auto-merge October 12, 2023 10:24
@seqan-actions seqan-actions added lint [INTERNAL] used for linting and removed lint [INTERNAL] used for linting labels Oct 12, 2023
@smehringer smehringer merged commit e5c95f6 into seqan:main Oct 12, 2023
26 checks passed
@smehringer smehringer deleted the layout_fix branch October 18, 2023 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants