[MISC] add div_ceil #149
Merged
[MISC] add div_ceil #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
seqan-actions
added
lint
eseiler
force-pushed
the
misc/div_ceil
branch
from
2f500d3 to
5640b8c
Compare
seqan-actions
added
lint
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #149 +/- ##
=======================================
Coverage 98.33% 98.34%
=======================================
Files 41 42 +1
Lines 1385 1389 +4
=======================================
+ Hits 1362 1366 +4
Misses 23 23
☔ View full report in Codecov by Sentry. |
eseiler
commented
Oct 24, 2023
include/hibf/misc/div_ceil.hpp
Outdated
| template <std::unsigned_integral t1, std::unsigned_integral t2> | ||
| [[nodiscard]] inline constexpr size_t div_ceil(t1 const dividend, t2 const divisor) noexcept | ||
| { | ||
| assert(divisor > 0u); |
There was a problem hiding this comment.
Maybe also add an assert for overflow detection (dividend + divisor)
smehringer
reviewed
Oct 24, 2023
include/hibf/misc/div_ceil.hpp
Outdated
| * \ingroup hibf | ||
| */ | ||
| template <std::unsigned_integral t1, std::unsigned_integral t2> | ||
| [[nodiscard]] inline constexpr size_t div_ceil(t1 const dividend, t2 const divisor) noexcept |
There was a problem hiding this comment.
Suggested change
| [[nodiscard]] inline constexpr size_t div_ceil(t1 const dividend, t2 const divisor) noexcept | |
| [[nodiscard]] inline constexpr size_t divide_and_ceil(t1 const dividend, t2 const divisor) noexcept |
eseiler
force-pushed
the
misc/div_ceil
branch
from
5640b8c to
aa4bd49
Compare
seqan-actions
added
lint
eseiler
force-pushed
the
misc/div_ceil
branch
from
aa4bd49 to
c9f8466
Compare
seqan-actions
added
lint
smehringer
approved these changes
Oct 24, 2023
eseiler
force-pushed
the
misc/div_ceil
branch
from
c9f8466 to
db87a0e
Compare
seqan-actions
added
lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.